Skip to content

dockerfile: add missing mount completions#5245

Merged
tonistiigi merged 1 commit intomoby:masterfrom
ardrabczyk:add-missing-suggestions
Aug 13, 2024
Merged

dockerfile: add missing mount completions#5245
tonistiigi merged 1 commit intomoby:masterfrom
ardrabczyk:add-missing-suggestions

Conversation

@ardrabczyk
Copy link
Copy Markdown
Contributor

This list has now to be manually maintained but OTOH if keys were stored in a []string list there would be a risk that not all elements are used in switch.

Now users will get suggestions for misspelled "destination" and "size"
mount options:

    ERROR: failed to solve: unexpected key 'destinationn' in 'destinationn=/lol' (did you mean destination?)
    ERROR: failed to solve: unexpected key 'sizee' in 'sizee=1024' (did you mean size?)

Signed-off-by: Arkadiusz Drabczyk <[email protected]>
@tonistiigi tonistiigi merged commit 820417a into moby:master Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants