Proposal: Experimental Rulechecks#5213
Merged
tonistiigi merged 2 commits intomoby:masterfrom Aug 13, 2024
Merged
Conversation
Signed-off-by: Talon Bowler <[email protected]>
crazy-max
reviewed
Aug 6, 2024
dvdksn
reviewed
Aug 8, 2024
daghack
force-pushed
the
experimental-rule-checks
branch
2 times, most recently
from
c00dd4a to
587b081
Compare
Collaborator
|
I also think we should add something to the buildkit/frontend/dockerfile/linter/docs/_index.md Lines 32 to 35 in 27efea4 |
dvdksn
reviewed
Aug 8, 2024
daghack
force-pushed
the
experimental-rule-checks
branch
from
587b081 to
babcd06
Compare
dvdksn
reviewed
Aug 10, 2024
Signed-off-by: Talon Bowler <[email protected]>
daghack
force-pushed
the
experimental-rule-checks
branch
from
babcd06 to
a62980e
Compare
dvdksn
approved these changes
Aug 12, 2024
tonistiigi
approved these changes
Aug 13, 2024
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
This looks good, but we should still make sure we can remove the experimental opt-in from the CopyIgnoredFile rule with the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #5176
Implements the feature and updates the
CopyIgnoredFilerule check to be experimental through the new proposal.