ci: add OCI image annotations to Dockerfile frontend images#5197
Merged
crazy-max merged 3 commits intomoby:masterfrom Aug 8, 2024
Merged
ci: add OCI image annotations to Dockerfile frontend images#5197crazy-max merged 3 commits intomoby:masterfrom
crazy-max merged 3 commits intomoby:masterfrom
Conversation
Signed-off-by: Craig Andrews <[email protected]>
Contributor
Author
|
@crazy-max how's this PR look? |
Contributor
Author
|
@crazy-max friendly bump |
crazy-max
reviewed
Aug 6, 2024
crazy-max
reviewed
Aug 7, 2024
crazy-max
reviewed
Aug 7, 2024
crazy-max
requested changes
Aug 7, 2024
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Some changes so we can verify this on PR like the BuildKit image
Co-authored-by: CrazyMax <[email protected]> Signed-off-by: Craig Andrews <[email protected]>
Co-authored-by: CrazyMax <[email protected]> Signed-off-by: Craig Andrews <[email protected]>
Contributor
Author
Thank you, those changes look good to me and have been applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://github.com/opencontainers/image-spec/blob/main/annotations.md#pre-defined-annotation-keys
Closes: #3553
Signed-off-by: Craig Andrews [email protected]