Add environment replacement support for chmod option#5151
Merged
crazy-max merged 1 commit intomoby:masterfrom Aug 6, 2024
Merged
Add environment replacement support for chmod option#5151crazy-max merged 1 commit intomoby:masterfrom
crazy-max merged 1 commit intomoby:masterfrom
Conversation
tonistiigi
reviewed
Jul 12, 2024
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
I think this is fine to add but we need an integration test in dockerfile_test .
@AkihiroSuda sgty?
Member
SGTM |
Contributor
Author
|
One build test image crashed with SEGV, but I don't remember making any changes that would cause this to happen, and other combinations of matrix seem to complete normally. |
kariya-mitsuru
force-pushed
the
add-env-replace-for-chmod
branch
from
a5755b1 to
591c23d
Compare
tonistiigi
approved these changes
Jul 23, 2024
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
LGTM, but squash the commits please (or fix the commit message for second commit).
Add environment replacement support for chmod option argument for the ADD and COPY commands. Signed-off-by: Mitsuru Kariya <[email protected]>
kariya-mitsuru
force-pushed
the
add-env-replace-for-chmod
branch
from
591c23d to
22fbeaf
Compare
Member
|
@dvdksn I think we need some docs follow-up for this one. |
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add environment replacement support for chmod option argument for the ADD and COPY commands.