Check invalid environment replacement form like ${VAR:%}#5146
Merged
tonistiigi merged 1 commit intomoby:masterfrom Aug 12, 2024
Merged
Check invalid environment replacement form like ${VAR:%}#5146tonistiigi merged 1 commit intomoby:masterfrom
tonistiigi merged 1 commit intomoby:masterfrom
Conversation
Environment replacement form like below are invalid, so they should
cause error.
- `${VAR:#pattern}`
- `${VAR:##pattern}`
- `${VAR:%pattern}`
- `${VAR:%%pattern}`
Signed-off-by: Mitsuru Kariya <[email protected]>
Member
|
LGTM |
jsternberg
approved these changes
Aug 5, 2024
Collaborator
jsternberg
left a comment
jsternberg
left a comment
There was a problem hiding this comment.
Seems fine. As a note for the future, this lexing code is getting sufficiently complicated enough that using a lexer generator may end up being easier to reason with and maintain. That's not important for this PR though.
tonistiigi
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment replacement form like below are invalid, so they should cause error.
${VAR:#pattern}${VAR:##pattern}${VAR:%pattern}${VAR:%%pattern}