Pass cache imports from solve ptions to solve request#5143
Merged
jedevc merged 2 commits intomoby:masterfrom Jul 16, 2024
Merged
Pass cache imports from solve ptions to solve request#5143jedevc merged 2 commits intomoby:masterfrom
jedevc merged 2 commits intomoby:masterfrom
Conversation
Signed-off-by: Ignas Mikalajunas <[email protected]>
Ignas
force-pushed
the
pass-cache-imports-to-solve
branch
from
28bb5dc to
955f289
Compare
Tzvonimir
approved these changes
Jul 10, 2024
tonistiigi
approved these changes
Jul 16, 2024
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
I'm not sure if it is intentional that this is not working automatically. The cache source from the initial request could be always included, unless there is some use case where frontend absolutely wants to ignore them.
jedevc
approved these changes
Jul 16, 2024
Member
jedevc
left a comment
jedevc
left a comment
There was a problem hiding this comment.
Ah, I had also noticed this at some point 🎉 Thanks for putting a patch together!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment build --import-cache option is ignored when not using any frontend. This makes sure the option is passed along to the actual solve request.