ensure correct grpc max sizes for control API and frontends#4969
Merged
thompson-shaun merged 1 commit intomoby:masterfrom May 30, 2024
Merged
ensure correct grpc max sizes for control API and frontends#4969thompson-shaun merged 1 commit intomoby:masterfrom
thompson-shaun merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
commented
May 30, 2024
| grpc.WithTransportCredentials(insecure.NewCredentials()), | ||
| grpc.WithUnaryInterceptor(grpcerrors.UnaryClientInterceptor), | ||
| grpc.WithStreamInterceptor(grpcerrors.StreamClientInterceptor), | ||
| grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(16 << 20)), |
Member
Author
There was a problem hiding this comment.
Left these to direct values as this code is used in external frontends and better to avoid new dependencies.
crazy-max
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4948
Correct app default should be 16MB but were control API and frontends used library defaults.
Signed-off-by: Tonis Tiigi [email protected]