feat: handle mirror url with path#3427
Merged
tonistiigi merged 2 commits intomoby:masterfrom Dec 20, 2022
Merged
Conversation
JordanGoasdoue
force-pushed
the
chore-allow-mirror-path
branch
from
10067f5 to
6be743d
Compare
JordanGoasdoue
changed the title
tonistiigi
approved these changes
Dec 20, 2022
Member
|
@JordanGoasdoue PTAL the windows CI error |
JordanGoasdoue
force-pushed
the
chore-allow-mirror-path
branch
7 times, most recently
from
1e23101 to
f4bf4f0
Compare
Signed-off-by: JordanGoasdoue <[email protected]>
JordanGoasdoue
force-pushed
the
chore-allow-mirror-path
branch
from
f4bf4f0 to
e662e1d
Compare
Contributor
Author
|
@tonistiigi thanks for the review, should be good now after i've replaced |
JordanGoasdoue
force-pushed
the
chore-allow-mirror-path
branch
from
80f3c86 to
ff49f3c
Compare
JordanGoasdoue
force-pushed
the
chore-allow-mirror-path
branch
from
ff49f3c to
e621319
Compare
Signed-off-by: JordanGoasdoue <[email protected]>
JordanGoasdoue
force-pushed
the
chore-allow-mirror-path
branch
from
e621319 to
7f67670
Compare
tonistiigi
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the use of mirror registry such as Harbor in buildkit with the possibility to have one registry host and multiple proxy_cache projects inside
example:
buildkit side:
harbor side:
Let's take this Dockerfile to be built by buildkit:
With the mirror configuration above, buildkit will pull ubuntu:22.04 from
core.harbor.domain/proxy.docker.io/library/ubuntu:22.04