ci: align test flags#3031
Merged
Merged
Conversation
Signed-off-by: CrazyMax <[email protected]>
tonistiigi
approved these changes
Aug 18, 2022
emmanuelguerin
pushed a commit
to emmanuelguerin/buildkit
that referenced
this pull request
Mar 31, 2025
bake: support += operator to append with overrides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #3024 (comment)
Align test flags for linux and windows runners.
I tested with an extended matrix for windows runners: https://github.com/crazy-max/buildkit/actions/runs/2866740805
windows-2019/go 1.18.1:github.com/moby/buildkit/util/flightcontrol 713.146s coverage: 65.8% of statementswindows-2022/go 1.18.1:github.com/moby/buildkit/util/flightcontrol 444.752s coverage: 65.8% of statementswindows-2019/go 1.18.2:github.com/moby/buildkit/util/flightcontrol 804.799s coverage: 65.8% of statementswindows-2022/go 1.18.2:github.com/moby/buildkit/util/flightcontrol 338.622s coverage: 65.8% of statementswindows-2019/go 1.18.3:github.com/moby/buildkit/util/flightcontrol 600.374s coverage: 65.8% of statementswindows-2022/go 1.18.3:github.com/moby/buildkit/util/flightcontrol 416.163s coverage: 65.2% of statementswindows-2019/go 1.18.4:github.com/moby/buildkit/util/flightcontrol 4.589s coverage: 65.8% of statementswindows-2022/go 1.18.4:github.com/moby/buildkit/util/flightcontrol 286.434s coverage: 65.8% of statementswindows-2019/go 1.18.5:github.com/moby/buildkit/util/flightcontrol 647.428s coverage: 65.8% of statementswindows-2022/go 1.18.5:github.com/moby/buildkit/util/flightcontrol 687.715s coverage: 65.8% of statementsAnd it seems to depend on the runner (workload?) and not Go or BuildKit.
Signed-off-by: CrazyMax [email protected]