executor: make sure supplementary groups are set for unset user#2428
executor: make sure supplementary groups are set for unset user#2428tonistiigi merged 3 commits intomoby:masterfrom
Conversation
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
default-user-groups
branch
from
995e87f to
e82ccdf
Compare
|
Code LGTM in terms of fixing the linked issue, my only question is if there's any backwards compatibility concerns. It seems like users running buildkit with an unset user will now have potentially more supplemental groups than before. It's probably very rare that anyone would actually care, but is this the type of thing we want to add a capability for so users can check the behavior? |
|
It is pretty clearly in the bug territory though as this is what happens if you do set |
sipsma
left a comment
sipsma
left a comment
There was a problem hiding this comment.
Sounds good about the cap question, just wanted to double check
|
<3 thanks for fixing this @tonistiigi , I'm sorry it was out of my league to fix this myself |
4 participants
fixes #2341
Ensure that unset user has same supplementary groups as root.
Signed-off-by: Tonis Tiigi [email protected]