move RegistryConfig to resolver package#2151
Conversation
|
Ah, hm.. messed up. Fixing |
thaJeztah
force-pushed
the
move_config_opt
branch
from
2b03d79 to
097cbab
Compare
|
@tonistiigi @AkihiroSuda ptal |
cmd/buildkitd/config/config.go
Outdated
| Key string `toml:"key"` | ||
| Certificate string `toml:"cert"` | ||
| } | ||
| type RegistryConfig = resolver.RegistryConfig |
There was a problem hiding this comment.
Is this needed? Just adds confusion probably.
There was a problem hiding this comment.
Did a quick search on grep.app (https://grep.app/search?q=github.com/moby/buildkit/cmd/buildkitd/config&filter[lang][0]=Go), and looks like (besides moby), it's only https://github.com/genuinetools/img using it. For that repo, should be a quick fix to update as well https://github.com/genuinetools/img/blob/89fb42e58c5ffc73774f0e9a97824810c15ea775/vendor/github.com/moby/buildkit/util/resolver/resolver.go
Let me remove the alias
This allows using the resolver package without having to import the buildkit daemon configuration. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
move_config_opt
branch
from
097cbab to
12c9920
Compare
2 participants
relates to moby/moby#42465 (comment)
This allows using the resolver package without having to import the buildkit daemon configuration.
Aliasses were added in the config package for backward compatibility, and to allow for the config package to diverge / extend the internal type if needed.