Skip to content

feat(run-mount): add support for variable expansion#2089

Merged
tonistiigi merged 1 commit intomoby:masterfrom
omermizr:feature/run-mount-variables
May 6, 2021
Merged

feat(run-mount): add support for variable expansion#2089
tonistiigi merged 1 commit intomoby:masterfrom
omermizr:feature/run-mount-variables

Conversation

@omermizr
Copy link

@omermizr omermizr commented Apr 26, 2021

This PR adds support for variable expansion in RUN mounts.
Resolves #815

Caveats:

  • from expansion is not supported.
  • Expansion is not supported in ONBUILD RUN commands (I don't even think mounts work there).

@omermizr
Copy link
Author

omermizr commented Apr 26, 2021

@tonistiigi FYI

tonistiigi
tonistiigi reviewed Apr 26, 2021
View reviewed changes
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing DCO

I don't fully get the changes in convert.go. If it is just refactoring with no functional changes it should be in a different PR.

This doesn't fix the issues with output afaics. Fine by me if you want to tackle this in follow-up but should be fixed as well.

@omermizr omermizr force-pushed the feature/run-mount-variables branch from 4ca939e to 1f39eb8 Compare May 1, 2021 18:10
@omermizr
Copy link
Author

omermizr commented May 1, 2021

Added DCOs.
Removed changes in convert.go.
Regarding output formatting - I think it's beyond the scope of this PR, especially considering it's an existing problem. I also don't wanna mix a feature branch with a fix branch. I can make a separate PR to fix it, but I couldn't figure out where that code is. If you can send me on a path that'd be great :)

tonistiigi
tonistiigi reviewed May 2, 2021
View reviewed changes
tonistiigi
tonistiigi reviewed May 2, 2021
View reviewed changes
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small comments left. Make sure to also squash commits and verify CI

@omermizr omermizr force-pushed the feature/run-mount-variables branch from 590ab7d to 7dd7a67 Compare May 3, 2021 07:08
@omermizr omermizr force-pushed the feature/run-mount-variables branch from 71c8bf4 to 1ac4230 Compare May 5, 2021 06:36
tonistiigi
tonistiigi reviewed May 5, 2021
View reviewed changes
@omermizr omermizr force-pushed the feature/run-mount-variables branch from 1ac4230 to aa46719 Compare May 5, 2021 09:49
@tonistiigi tonistiigi merged commit 1465ce5 into moby:master May 6, 2021
@umarcor umarcor mentioned this pull request May 7, 2021
Closed
@thaJeztah thaJeztah mentioned this pull request Jun 7, 2021
Merged
2 tasks
@tonistiigi tonistiigi mentioned this pull request Jun 14, 2021
Closed
@darkdragon-001 darkdragon-001 mentioned this pull request Aug 1, 2021
Open
@crazy-max crazy-max mentioned this pull request Aug 3, 2021
Closed
@tonistiigi tonistiigi mentioned this pull request Aug 12, 2021
Merged
@damienleger damienleger mentioned this pull request Oct 7, 2021
Closed
@umarcor umarcor mentioned this pull request Oct 13, 2021
Open
@dln22 dln22 mentioned this pull request Jun 15, 2022
Closed
@jedevc jedevc mentioned this pull request Nov 22, 2022
Closed
@rschroll rschroll mentioned this pull request Jul 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature request: allow variables in the RUN --mount=type=bind values

2 participants

@omermizr @tonistiigi