Revert "Ensure ENTRYPOINT command has at least one argument" #1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 174bcf8. This commit attempted to fix a situation where an empty entrypoint was specified, causing a confusing error when running the image, however, allowing the entrypoint to be reset should be a valid use-case, and running such image on docker 20.10 at least produces an informative error; docker build -t foo -<<'EOF' FROM busybox ENTRYPOINT [] EOF Or, to reset a previously set entrypoint: docker build -t foo -<<'EOF' FROM busybox AS one ENTRYPOINT ["/bin/busybox"] FROM one AS two ENTRYPOINT [] EOF If no command is specified for the image above: docker run -it --rm foo docker: Error response from daemon: No command specified. See 'docker run --help'. Passing a command to run: docker run -it --rm foo sh /# Given that this commit resulted in a regression/breaking change this reverts the commit. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
ping @tonistiigi @AkihiroSuda @tiborvass PTAL Also see moby/moby#7806, which added a test-case for this use-case, which showed the regression (moby/moby@78a847a) |
tiborvass
approved these changes
Dec 3, 2020
Collaborator
|
Is TestRuncWorker flaky? |
Member
Not essentially linked to this PR, appears a while ago AFAIK |
Collaborator
|
@chang-andrew FYI we had to revert your change, we didn't realize it was a breaking change for valid use cases. Sorry about that! Looks like #1119 was a formatting issue in containerd 1.2 that was fixed in subsequent releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 174bcf8 (#1862),
This commit attempted to fix a situation where an empty entrypoint was specified, causing a confusing error when running the image (#1119), however, allowing the entrypoint to be reset should be a valid use-case, and running such image on docker 20.10 at least produces an informative error;
Or, to reset a previously set entrypoint:
If no command is specified for the image above:
Passing a command to run:
Given that this commit resulted in a regression/breaking change this reverts the commit. (see moby/moby#41745)