cache: force overlay readonly by removing upperdir #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]>
tiborvass
approved these changes
Jul 30, 2019
Member
|
LGTM |
laurazard
added a commit
to laurazard/containerd
that referenced
this pull request
Mar 13, 2023
This is necessary so we can mount snapshots more than once with overlayfs, otherwise mounts enter an unknown state. related: moby/buildkit#1100 Signed-off-by: Laura Brehm <[email protected]> Co-authored-by: Zou Nengren <[email protected]>
laurazard
added a commit
to laurazard/containerd
that referenced
this pull request
Mar 15, 2023
This is necessary so we can mount snapshots more than once with overlayfs, otherwise mounts enter an unknown state. related: moby/buildkit#1100 Signed-off-by: Laura Brehm <[email protected]> Co-authored-by: Zou Nengren <[email protected]>
laurazard
added a commit
to laurazard/containerd
that referenced
this pull request
Mar 16, 2023
This is necessary so we can mount snapshots more than once with overlayfs, otherwise mounts enter an unknown state. related: moby/buildkit#1100 Signed-off-by: Laura Brehm <[email protected]> Co-authored-by: Zou Nengren <[email protected]>
laurazard
added a commit
to laurazard/containerd
that referenced
this pull request
Mar 17, 2023
This is necessary so we can mount snapshots more than once with overlayfs, otherwise mounts enter an unknown state. related: moby/buildkit#1100 Signed-off-by: Laura Brehm <[email protected]> Co-authored-by: Zou Nengren <[email protected]>
laurazard
added a commit
to laurazard/containerd
that referenced
this pull request
Mar 17, 2023
This is necessary so we can mount snapshots more than once with overlayfs, otherwise mounts enter an unknown state. related: moby/buildkit#1100 Signed-off-by: Laura Brehm <[email protected]> Co-authored-by: Zou Nengren <[email protected]>
laurazard
added a commit
to laurazard/containerd
that referenced
this pull request
Mar 22, 2023
This is necessary so we can mount snapshots more than once with overlayfs, otherwise mounts enter an unknown state. related: moby/buildkit#1100 Signed-off-by: Laura Brehm <[email protected]> Co-authored-by: Zou Nengren <[email protected]> (cherry picked from commit daa3a76)
laurazard
added a commit
to laurazard/containerd
that referenced
this pull request
Mar 22, 2023
This is necessary so we can mount snapshots more than once with overlayfs, otherwise mounts enter an unknown state. related: moby/buildkit#1100 Signed-off-by: Laura Brehm <[email protected]> Co-authored-by: Zou Nengren <[email protected]> (cherry picked from commit daa3a76) Signed-off-by: Laura Brehm <[email protected]>
jsturtevant
pushed a commit
to jsturtevant/containerd
that referenced
this pull request
Sep 21, 2023
This is necessary so we can mount snapshots more than once with overlayfs, otherwise mounts enter an unknown state. related: moby/buildkit#1100 Signed-off-by: Laura Brehm <[email protected]> Co-authored-by: Zou Nengren <[email protected]>
juliusl
pushed a commit
to juliusl/containerd
that referenced
this pull request
Jan 26, 2024
This is necessary so we can mount snapshots more than once with overlayfs, otherwise mounts enter an unknown state. related: moby/buildkit#1100 Signed-off-by: Laura Brehm <[email protected]> Co-authored-by: Zou Nengren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1091
Add a special handling for readonly overlay mounts from active snapshots that removes the upper directory.
@dmcgowan @denzp
@dmcgowan While I think this is fine to do in cases buildkit already knows mount is readonly I think there should be some lower-level protection because the APIs all support getting multiple mounts. I would expect ref counting for overlay mount lifecycle in containerd so it doesn't crash on runtime or if this is not possible I think I need to add a refcounting snapshot wrapper in buildkit.
Signed-off-by: Tonis Tiigi [email protected]