This repository was archived by the owner on Dec 31, 2020. It is now read-only.
Issue #838: Clarify use of PureComponent and memo in changelog#842
Merged
danielkcz merged 5 commits intomobxjs:masterfrom Feb 26, 2020
Merged
Issue #838: Clarify use of PureComponent and memo in changelog#842danielkcz merged 5 commits intomobxjs:masterfrom
danielkcz merged 5 commits intomobxjs:masterfrom
Conversation
Contributor
|
Well, that even adds more confusion :) I mean class components are ok, but functional ones have Anyway, I think it would be generally better to have more elaborate explanation in README and link that in changelog instead of copying it over. |
Contributor
Author
|
Oops. You're right. My fault. I'll make it more brief and then just link to the updated README. |
ynejati
commented
Feb 25, 2020
ynejati
commented
Feb 25, 2020
ynejati
commented
Feb 25, 2020
ynejati
commented
Feb 25, 2020
vkrol
suggested changes
Feb 25, 2020
danielkcz
reviewed
Feb 25, 2020
…Component update to lowercase as well.
danielkcz
approved these changes
Feb 26, 2020
Contributor
danielkcz
left a comment
danielkcz
left a comment
There was a problem hiding this comment.
Just a few last tweaks and we are good to go.
vkrol
approved these changes
Feb 26, 2020
vkrol
suggested changes
Feb 26, 2020
Co-Authored-By: Veniamin Krol <[email protected]>
Contributor
|
Thanks @ynejati |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the changelog in response to #838. Should we update the README as well in better detail?
README.....if applicable?