Repository navigation
fix(mobx): include observableKind and debugObjectName in observe events of boxed values - #4761
Merged
Merged
Conversation
…ts of boxed values
🦋 Changeset detectedLatest commit: dbec9aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
Thanks |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
observeon a boxed observable, an observable object property or an observable map entry deliversupdateevents withoutobservableKindanddebugObjectName, althoughIValueDidChangedeclares both as required and the docs list them for every observe event. ThefireImmediatelyevent inobservealready includes them, so a listener sees them on the first call andundefinedon every later one:The fix adds the two fields to the change object in
ObservableValue.setNewValue_. The object is only built when a listener is registered, so nothing changes otherwise.Code change checklist
/docs. For new functionality, at leastAPI.mdshould be updated (not needed, the docs already describe this behaviour)npm -w mobx run test:performance) (the script is a shell script and I couldn't run it on Windows; the change adds two properties to an object that is only created when there are listeners)