Sorry to not respond to this earlier, I got reminded of this when looking at mosh-chrome issues.

This actually looks reasonable, and I'm considering pulling it for the next version of Mosh. The one thing I want to think about is that a 100KB paste is a relatively large object to be passing in a single SSP message, and I see a bit of potential for excessively-large messages getting packets dropped by too-short network queues, causing the session to stall.

Mosh has only ever promised to deliver a faithful, usable terminal window to the client; it's never promised to deliver any particular sequence of bytes reliably from server to client. This patch would bend that slightly, and it does require some arbitrary size limit (100KB actually seems fairly reasonable).

Thanks for the feedback. Changed max clipboard size to 16k, I think that is more than enough for most uses of the clipboard.

Hi, will this patch resolve the following:
MacOs Sierra 10.12.5 ->
ITerm2 3.0.15 -> "Applications in terminal may access clipboard" checkbox is set in preferences-general ->
ssh to centos 7 server -> start tmux 2.2 -> copy some text to tmux buffer -> this text also copied to mac clipboard

If I change ssh to mosh, tmux buffer doesn't appear in mac clipboard. Looks like tmux is using osc 52 to do that? If this patch would fix that, that would be awesome)

Yup, it will fix that too.

Wow, cool. Sorry, dumb question: do I need to patch both server and client side to make it work? I want to try to build it

Ok, I tried to build just client, and connecting with new client to old mosh server did not fix the issue with tmux clipboard that I described before.

Pulled. Thanks!

@acornejo I forgot to follow up about the source-code formatting:

Where do you find the source code style to be badly inconsistent? I find it mostly consistent with Emacs formatting set for cc-mode, with 8-character tab stops, and KeithW's odd style of including spaces in parentheses in most contexts. ocb.cc is a major exception, because that was copied into the project, and there's value in retaining that security-critical code as contributed, for ease of comparison with the original and other forks. There's a few other files that are a little inconsistent but I haven't found it a major issue.

I personally would like to reformat the source (and get rid of the spaces around the parens, which really annoy me), but that's a project-wide decision.

I'd certainly like to see your clang-format machinery, or at least the clang-format invocation you use, to see what we might get-- I haven't used it much myself, and not for quite a while.

Ok, I tried to build just client, and connecting with new client to old mosh server did not fix the issue with tmux clipboard that I described before.

Yep, you need to build the server and the client.