commands/input.go (1)

80-98: Add validation for the duration parameter.

The duration parameter is passed through without validation. Consider adding bounds checking similar to the coordinate validation to prevent negative, zero, or unreasonably large duration values that could cause unexpected behavior.

🔎 Proposed validation

 func LongPressCommand(req LongPressRequest) *CommandResponse {
 	if req.X < 0 || req.Y < 0 {
 		return NewErrorResponse(fmt.Errorf("x and y coordinates must be non-negative, got x=%d, y=%d", req.X, req.Y))
 	}
+
+	if req.Duration <= 0 || req.Duration > 60000 {
+		return NewErrorResponse(fmt.Errorf("duration must be between 1 and 60000 milliseconds, got %d", req.Duration))
+	}
 
 	targetDevice, err := FindDeviceOrAutoSelect(req.DeviceID)

devices/simulator.go (1)

638-640: Consider adding duration validation.

The duration parameter is passed directly to the WDA client without validation. Consider adding bounds checking (e.g., duration > 0 and reasonable upper limit) to catch invalid values early and provide clearer error messages.

🔎 Suggested validation

 func (s SimulatorDevice) LongPress(x, y, duration int) error {
+	if duration <= 0 {
+		return fmt.Errorf("duration must be positive, got %d", duration)
+	}
+	if duration > 60000 {
+		return fmt.Errorf("duration %d ms exceeds maximum of 60000 ms", duration)
+	}
 	return s.wdaClient.LongPress(x, y, duration)
 }

devices/android.go (1)

322-329: Consider adding duration validation.

The duration parameter is passed directly to the adb command without validation. Consider adding bounds checking (e.g., duration > 0 and reasonable upper limit) to prevent invalid adb commands and provide clearer error messages.

🔎 Suggested validation

 func (d *AndroidDevice) LongPress(x, y, duration int) error {
+	if duration <= 0 {
+		return fmt.Errorf("duration must be positive, got %d", duration)
+	}
+	if duration > 60000 {
+		return fmt.Errorf("duration %d ms exceeds maximum of 60000 ms", duration)
+	}
 	_, err := d.runAdbCommand("shell", "input", "swipe", fmt.Sprintf("%d", x), fmt.Sprintf("%d", y), fmt.Sprintf("%d", x), fmt.Sprintf("%d", y), fmt.Sprintf("%d", duration))
 	if err != nil {
 		return err
 	}

 	return nil
 }

devices/wda/longpress.go (1)

7-37: Consider adding duration validation and documentation.

The implementation correctly uses the duration parameter in the pause action. However, consider:

1. Adding bounds checking for the duration parameter (e.g., positive value, reasonable upper limit)
2. Adding a comment documenting that duration is in milliseconds

🔎 Suggested improvements

+// LongPress performs a long press at the specified coordinates for the given duration (in milliseconds).
 func (c *WdaClient) LongPress(x, y, duration int) error {
+	if duration <= 0 {
+		return fmt.Errorf("duration must be positive, got %d", duration)
+	}
+	if duration > 60000 {
+		return fmt.Errorf("duration %d ms exceeds maximum of 60000 ms", duration)
+	}

 	sessionId, err := c.GetOrCreateSession()
 	if err != nil {
 		return err
 	}

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro