Skip to content

fix: removed no-window again from emulator start, headless is horribl… #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gmegidish merged 1 commit into from
Dec 10, 2025
Merged

fix: removed no-window again from emulator start, headless is horribl… #136

gmegidish merged 1 commit into from
Dec 10, 2025

Conversation

@gmegidish
Copy link
Member

@gmegidish gmegidish commented Dec 10, 2025 •
edited by coderabbitai bot
Loading

…y slow

Summary by CodeRabbit

  • Bug Fixes
    • Android emulator now displays its window when booting, allowing users to visually monitor the startup process and device initialization.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 10, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Modified the Boot() method in AndroidDevice to start the emulator without the -no-window flag, enabling visible emulator window display. Boot orchestration, timeout handling, and post-boot state updates remain unchanged.

Changes

Cohort / File(s) Summary
Android emulator boot configuration
devices/android.go		 Removed -no-window flag from emulator launch to allow emulator window visibility

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-removed-no-window-again
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 762dd2d and f7fb404.

📒 Files selected for processing (1)
  • devices/android.go (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish merged commit 7635259 into main Dec 10, 2025
6 of 7 checks passed
@gmegidish gmegidish deleted the fix-removed-no-window-again branch December 10, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmegidish