Skip to content

fix: allow negative coordinates when swiping #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gmegidish merged 1 commit into from
Dec 8, 2025
Merged

fix: allow negative coordinates when swiping #130

gmegidish merged 1 commit into from
Dec 8, 2025

Conversation

@gmegidish
Copy link
Member

@gmegidish gmegidish commented Dec 8, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Expanded swipe command input handling to accept a broader range of coordinate values previously rejected.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 8, 2025 •
edited
Loading

Walkthrough

Removed input validation in SwipeCommand that rejected negative coordinates. The function now skips the coordinate sign validation and proceeds directly to device location, agent startup, and swipe execution. Error handling and success messaging remain unchanged.

Changes

Cohort / File(s) Change Summary
Input Command Updates
commands/input.go		 Removed input validation that rejected negative coordinates in SwipeCommand function. Coordinate sign checking now bypassed; device location, agent startup, and swipe execution proceed without coordinate validation.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: removing validation that rejected negative coordinates in the swipe command.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-allow-negative-coordinates
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 03174fe and 76a0130.

📒 Files selected for processing (1)
  • commands/input.go (0 hunks)
💤 Files with no reviewable changes (1)
  • commands/input.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: lint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish merged commit 916c32c into main Dec 8, 2025
15 checks passed
@gmegidish gmegidish deleted the fix-allow-negative-coordinates branch December 14, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmegidish