Skip to content

fix: send home button after wda start in simulator #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gmegidish merged 5 commits into from
Dec 1, 2025
Merged

fix: send home button after wda start in simulator #127

gmegidish merged 5 commits into from
Dec 1, 2025

Conversation

@gmegidish
Copy link
Member

@gmegidish gmegidish commented Dec 1, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Improved simulator initialization to ensure proper background execution and stability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The StartAgent method in the simulator device module now includes a sequence to press the HOME button and wait 1 second after the WebDriverAgent becomes ready. This ensures the WebDriverAgent process runs in the background before proceeding with agent initialization.

Changes

Cohort / File(s) Summary
WebDriverAgent background initialization
devices/simulator.go		 Added HOME button press and 1-second sleep in StartAgent after WebDriverAgent readiness check to ensure WDA runs in the background

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-send-home-button-after-wda-start
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b160bd4 and 7dfcbed.

📒 Files selected for processing (1)
  • devices/simulator.go (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish merged commit 09a027e into main Dec 1, 2025
7 checks passed
@gmegidish gmegidish deleted the feat-send-home-button-after-wda-start branch December 1, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmegidish