commands/orientation.go (1)

33-36: Orientation commands correctly updated; consider small helper to reduce repetition

Both orientation commands now use device.StartAgent(devices.StartAgentConfig{}), which is correct for the new API. Given this pattern appears in many commands, you might later extract a small helper like StartAgentOrError(device) to centralize the boilerplate and error message wording, but it’s not required for this PR.

Also applies to: 63-66

commands/screenshot.go (1)

11-13: Screenshot command migration to StartAgentConfig is sound

Importing devices and calling targetDevice.StartAgent(devices.StartAgentConfig{}) aligns with the new interface, and leaves the screenshot behavior intact. If you later add longer-running capture steps here, this would be a natural place to thread an OnProgress callback through the config.

Also applies to: 57-60

commands/input.go (1)

7-9: Input commands consistently migrated to config-based StartAgent

All interaction commands now call targetDevice.StartAgent(devices.StartAgentConfig{}) with unchanged error handling, which is exactly what the new interface requires. Given how many commands share the same “find device → start agent → perform action” pattern, you might later introduce a small shared helper to reduce duplication, but it’s fine to keep as-is for now.

Also applies to: 63-66, 89-92, 115-118, 141-144, 167-170, 208-211

cli/device.go (1)

7-8: CLI device info uses new StartAgentConfig correctly; consider avoiding double-start

The deviceInfoCmd now calls targetDevice.StartAgent(devices.StartAgentConfig{}), which is the right way to use the new interface. Note that commands.InfoCommand also does its own FindDeviceOrAutoSelect + StartAgent, so the agent will typically be started twice on this path. That behavior predates this PR but could be tightened up later by letting either the CLI or the command package own agent startup, not both.

Also applies to: 50-56

devices/common.go (1)

11-18: Config types and interface changes look solid; add central normalization for ScreenCaptureConfig

The introduction of:

• ScreenCaptureConfig (with Format, Quality, Scale, OnProgress, OnData),
• StartAgentConfig (with OnProgress),
• and the corresponding ControllableDevice updates

is a good fit for the MJPEG use case and future extensibility.

Given you now have DefaultMJPEGQuality, DefaultMJPEGScale (0.1–1.0 range), and DefaultMJPEGFramerate here, consider adding a small helper in this package to normalize ScreenCaptureConfig (e.g., apply defaults when fields are zero, and clamp Quality/Scale into supported ranges). That keeps device-specific implementations from re‑implementing slightly different validation logic and ensures the defaults are applied consistently everywhere.

Something along these lines in this package would be enough, to be called by each implementation:

+func NormalizeScreenCaptureConfig(cfg ScreenCaptureConfig) ScreenCaptureConfig {
+	if cfg.Quality <= 0 || cfg.Quality > 100 {
+		cfg.Quality = DefaultMJPEGQuality
+	}
+	if cfg.Scale <= 0 {
+		cfg.Scale = DefaultMJPEGScale
+	}
+	// optional: clamp maximum scale or handle missing format defaults here
+	return cfg
+}

Also applies to: 20-33, 39-69

cli/screenshot.go (1)

88-98: Consider exposing quality as a CLI flag for consistency.

The scale parameter is now configurable via --scale, but quality is hardcoded to devices.DefaultMJPEGQuality. For consistency with the screenshot command (which has --quality), consider adding a --quality flag for screencapture as well.

This is optional since the current default (80) is reasonable.

devices/ios.go (1)

280-284: Progress message sent before returning error may be misleading.

The progress callback emits "Installing WebDriverAgent" but immediately returns an error stating WebDriverAgent is not installed. This could confuse users who see "Installing..." but then get an error instead of actual installation.

Consider either:

1. Removing this progress callback since no installation happens here
2. Or changing the message to something like "WebDriverAgent not found"

 		if webdriverBundleId == "" {
-			if config.OnProgress != nil {
-				config.OnProgress("Installing WebDriverAgent")
-			}
 			return fmt.Errorf("WebDriverAgent is not installed")
 		}

server/server.go (1)

740-744: Use consistent logging for write errors.

Line 742 uses fmt.Println while the rest of the server uses log.Printf (line 195). Consider using consistent logging.

 		OnData: func(data []byte) bool {
 			_, writeErr := w.Write(data)
 			if writeErr != nil {
-				fmt.Println("Error writing data:", writeErr)
+				log.Printf("Error writing data: %v", writeErr)
 				return false
 			}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro