Skip to content

fix: wrong error message when simulator/emulator device is offline #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gmegidish merged 1 commit into from
Nov 20, 2025
Merged

fix: wrong error message when simulator/emulator device is offline #107

gmegidish merged 1 commit into from
Nov 20, 2025

Conversation

@gmegidish
Copy link
Member

@gmegidish gmegidish commented Nov 20, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Improved error messages for device and simulator startup procedures to clarify the correct command syntax using the --device flag.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 20, 2025 •
edited
Loading

Walkthrough

Two files updated with consistent error message changes in their StartAgent functions. Boot command instructions now include the --device flag in user-facing error messages, with no modifications to underlying logic or control flow.

Changes

Cohort / File(s) Summary
StartAgent error message updates
devices/android.go, devices/simulator.go		 Updated boot instruction error messages to include --device flag in command syntax (e.g., mobilecli device boot --device %s instead of mobilecli device boot %s)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A flag hops in, so small yet true,
Device boot messages, now shiny and new,
--device whispers through Android and Sim,
Instructions gleam brighter, no logic a-dim,
Oh what a hop, what a bouncy delight!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: correcting error messages when simulator/emulator devices are offline by adding the --device flag to the boot command instructions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-wrong-error-message
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c661856 and ce71ae7.

📒 Files selected for processing (2)
  • devices/android.go (1 hunks)
  • devices/simulator.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: lint
🔇 Additional comments (2)
devices/simulator.go (1)

451-467: Updated offline simulator hint is accurate and consistent

The revised error message correctly reflects the mobilecli device boot --device <udid> syntax and aligns with the Android path, without altering behavior.

devices/android.go (1)

387-395: Offline emulator guidance now matches actual CLI usage

The new error message correctly points users to mobilecli device boot --device <id> and keeps behavior unchanged, improving UX when the emulator is offline.

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish merged commit 12528fd into main Nov 20, 2025
15 checks passed
@gmegidish gmegidish deleted the fix-wrong-error-message branch November 20, 2025 21:45
@coderabbitai coderabbitai bot mentioned this pull request Nov 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmegidish