fix: increase timeout to 60 seconds for dump ui on ios

gmegidish · gmegidish · commit 2979f09f7712 · 2025-12-08T16:43:33.000+01:00
diff --git a/devices/wda/requests.go b/devices/wda/requests.go
@@ -24,10 +24,10 @@ type sessionRequest struct {
 	Capabilities sessionCapabilities `json:"capabilities"`
 }
 
-func (c *WdaClient) GetEndpoint(endpoint string) (map[string]interface{}, error) {
+func (c *WdaClient) getEndpointWithTimeout(endpoint string, timeout time.Duration) (map[string]interface{}, error) {
 	url := fmt.Sprintf("%s/%s", c.baseURL, endpoint)
 
-	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
+	ctx, cancel := context.WithTimeout(context.Background(), timeout)
 	defer cancel()
 
 	req, err := http.NewRequestWithContext(ctx, "GET", url, nil)
@@ -62,6 +62,10 @@ func (c *WdaClient) GetEndpoint(endpoint string) (map[string]interface{}, error)
 	return result, nil
 }
 
+func (c *WdaClient) GetEndpoint(endpoint string) (map[string]interface{}, error) {
+	return c.getEndpointWithTimeout(endpoint, 5*time.Second)
+}
+
 func (c *WdaClient) PostEndpoint(endpoint string, data interface{}) (map[string]interface{}, error) {
 	url := fmt.Sprintf("%s/%s", c.baseURL, endpoint)
 	jsonData, err := json.Marshal(data)
diff --git a/devices/wda/source.go b/devices/wda/source.go
@@ -3,6 +3,7 @@ package wda
 import (
 	"encoding/json"
 	"fmt"
+	"time"
 
 	"github.com/mobile-next/mobilecli/types"
 	"github.com/mobile-next/mobilecli/utils"
@@ -79,7 +80,7 @@ func filterSourceElements(source sourceTreeElement) []types.ScreenElement {
 func (c *WdaClient) GetSource() (map[string]interface{}, error) {
 	endpoint := "source?format=json"
 
-	result, err := c.GetEndpoint(endpoint)
+	result, err := c.getEndpointWithTimeout(endpoint, 60*time.Second)
 	if err != nil {
 		return nil, fmt.Errorf("failed to get source: %w", err)
 	}
@@ -91,7 +92,7 @@ func (c *WdaClient) GetSource() (map[string]interface{}, error) {
 func (c *WdaClient) GetSourceRaw() (interface{}, error) {
 	endpoint := "source?format=json"
 
-	result, err := c.GetEndpoint(endpoint)
+	result, err := c.getEndpointWithTimeout(endpoint, 60*time.Second)
 	if err != nil {
 		return nil, fmt.Errorf("failed to get source: %w", err)
 	}
diff --git a/devices/wda/types.go b/devices/wda/types.go
@@ -24,7 +24,7 @@ func NewWdaClient(hostPort string) *WdaClient {
 	return &WdaClient{
 		baseURL: baseURL,
 		httpClient: &http.Client{
-			Timeout: 5 * time.Second,
+			Timeout: 60 * time.Second,
 		},
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ func NewWdaClient(hostPort string) *WdaClient {`
`24`	`24`	`return &WdaClient{`
`25`	`25`	`baseURL: baseURL,`
`26`	`26`	`httpClient: &http.Client{`
`27`		`- Timeout: 5 * time.Second,`
	`27`	`+ Timeout: 60 * time.Second,`
`28`	`28`	`},`
`29`	`29`	`}`
`30`	`30`	`}`