fix: kill wda if StartAgent times out on simulator

gmegidish · gmegidish · commit 064f156854f8 · 2025-11-29T14:16:20.000+01:00
diff --git a/devices/simulator.go b/devices/simulator.go
@@ -605,6 +605,8 @@ func (s *SimulatorDevice) StartAgent(config StartAgentConfig) error {
 
 	err = s.wdaClient.WaitForAgent()
 	if err != nil {
+		// terminate the WDA process if it failed to start
+		_ = s.TerminateApp(webdriverPackageName)
 		return err
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -605,6 +605,8 @@ func (s *SimulatorDevice) StartAgent(config StartAgentConfig) error {`
`605`	`605`
`606`	`606`	`err = s.wdaClient.WaitForAgent()`
`607`	`607`	`if err != nil {`
	`608`	`+ // terminate the WDA process if it failed to start`
	`609`	`+ _ = s.TerminateApp(webdriverPackageName)`
`608`	`610`	`return err`
`609`	`611`	`}`
`610`	`612`