feat: add hideKeyboard event - #165
Merged
Merged
Conversation
dmitry-zaitsev
suggested changes
Sep 12, 2022
dmitry-zaitsev
left a comment
dmitry-zaitsev
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but please also add:
- iOS support as mentioned in a comment
- Integration test
Contributor
Author
I've updated the PR. could you please help to review it again? 🙇🏻 |
dmitry-zaitsev
approved these changes
Sep 12, 2022
dmitry-zaitsev
left a comment
dmitry-zaitsev
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thank you
rikur
pushed a commit
to rikur/maestro
that referenced
this pull request
Jul 10, 2026
* feat: add hideKeyboard event * add hideKeyboard into iosdriver * hideKeyboard iosdriver * add hideKeyboard integration test * Revert "add hideKeyboard integration test" This reverts commit 7018519. * hideKeyboard integration test * hideKeyboard test typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi @dmitry-zaitsev
description
I have an issue when try to
tapOna button that blocked by device keyboard.the UI before keyboard is showing
the UI after keyboard is showing
solution
I've tried to add
hideKeyboard()event to avoid that failed case (beforetapOn()desired button)