Skip to content

feature: AndroidTV-Remote navigation - #148

Merged
dmitry-zaitsev merged 7 commits into
mobile-dev-inc:mainfrom
depapp:feature/pressKeyRemote
Sep 9, 2022
Merged

feature: AndroidTV-Remote navigation#148
dmitry-zaitsev merged 7 commits into
mobile-dev-inc:mainfrom
depapp:feature/pressKeyRemote

Conversation

@depapp

@depapp depapp commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

hi all,

I've added AndroidTV Remote navigation to pressKey()

  • Remote Dpad Up
  • Remote Dpad Down
  • Remote Dpad Left
  • Remote Dpad Right
  • Remote Dpad Center
  • Remote Media Play Pause
  • Remote Media Stop
  • Remote Media Next
  • Remote Media Previous
  • Remote Media Rewind
  • Remote Media Fast Forward

please let me know if I miss anything 🙇🏻

Comment thread maestro-test/src/test/resources/034_press_key.yaml
Comment thread maestro-test/src/test/kotlin/maestro/test/IntegrationTest.kt

@dmitry-zaitsev dmitry-zaitsev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the submission - you are almost there, just need to update the test

@depapp

depapp commented Sep 9, 2022

Copy link
Copy Markdown
Contributor Author

Thank you for the submission - you are almost there, just need to update the test

hi @dmitry-zaitsev

thanks for the review, I've updated on ac69848

please let me know if I miss anything 🙇🏻

@dmitry-zaitsev dmitry-zaitsev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the contribution

@dmitry-zaitsev
dmitry-zaitsev merged commit bc9e382 into mobile-dev-inc:main Sep 9, 2022
@depapp
depapp deleted the feature/pressKeyRemote branch September 9, 2022 21:43
rikur pushed a commit to rikur/maestro that referenced this pull request Jul 10, 2026
* feature: add AndroidTV Remote navigation

* add pressKey new event to integration test

* fix typo

* Revert "fix typo"

This reverts commit 3197b2d.

* add new pressKey events

* fix failed test

* update ios driver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants