Skip to content

Fix parsing double type without decimal point - #68

Merged
mneudert merged 2 commits into
mneudert:masterfrom
nallwhy:fix_parsing_double_type_without_decimal_point
Nov 9, 2021
Merged

mneudert merged 2 commits into
mneudert:masterfrom
nallwhy:fix_parsing_double_type_without_decimal_point

Conversation

@nallwhy

@nallwhy nallwhy commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

InfluxDB can send double type values without a decimal point.
To handle this, use Float.parse/1 instead of String.to_float/1.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+1.0%) to 74.221% when pulling d135a1d on nallwhy:fix_parsing_double_type_without_decimal_point into 6fff364 on mneudert:master.

@coveralls

coveralls commented Nov 8, 2021 •

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 73.247% when pulling cd4d615 on nallwhy:fix_parsing_double_type_without_decimal_point into 6fff364 on mneudert:master.

@Ma233

Ma233 commented Nov 9, 2021 •

Copy link
Copy Markdown
Contributor

@nallwhy Hi, would you mind to fix the format? And add some tests like this https://github.com/mneudert/instream/pull/70/files#diff-f89c196f7418cccba10c7749d9fd1311a5ed164bab5338ec8a1a043efcfaad42

@nallwhy
nallwhy force-pushed the fix_parsing_double_type_without_decimal_point branch from d135a1d to cd4d615 Compare November 9, 2021 07:21
@nallwhy

nallwhy commented Nov 9, 2021

Copy link
Copy Markdown
Contributor Author

@nallwhy Hi, would you mind to fix the format? And add some tests like this https://github.com/mneudert/instream/pull/70/files#diff-f89c196f7418cccba10c7749d9fd1311a5ed164bab5338ec8a1a043efcfaad42

Thanks a lot!

@mneudert
mneudert merged commit 192c05f into mneudert:master Nov 9, 2021
@mneudert

mneudert commented Nov 9, 2021

Copy link
Copy Markdown
Owner

❤️ 💚 💙 💛 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants