Skip to content

Conversation

@larsoner
Copy link
Member

The bulk of this has to do with us no longer packaging Spyder in our installers and adjusting the install docs (mostly) minimally to comply with this change. #10707 and #11615 for example ask for something more comprehensive and aren't meant to be addressed here. This does help a tiny bit (maybe!) with #10707 in the sense that it deduplicates some stuff. I also snuck in a couple of tiny single-digit-line changes to close three other issues:

  1. Pinning numpy<3
  2. Adding a note that compute_rank operates on data channels
  3. Improving an error message

@hoechenberger for the Spyder stuff, think this is good enough?

Closes #12672
Closes #12705
Closes #11540
Closes #11482

@larsoner
Copy link
Member Author

Updated pages: installers and IDEs.

Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @hoechenberger should probably have the final say.

@hoechenberger
Copy link
Member

hoechenberger commented Jul 16, 2024

Thanks @larsoner
I'm not so happy about the changes regarding VS Code setup, because the current set of changes removes some informative instructions -- running code from the MNE Prompt

Also I think having the VS Code instructions in installer.rst emphasizes that we consider VS Code the IDE of choice, even for installer users 🤔

@larsoner
Copy link
Member Author

I'm not so happy about the changes regarding VS Code setup, because the current set of changes removes some informative instructions -- running code from the MNE Prompt

So our old / current instructions have this on the main page:

image

Is this what you mean? What is there now is:

image

I don't think this is appreciably harder for the user, and it's more general (works on Windows!). But I guess I could add a note that the prompt might already tell you this information on some systems.

Also I think having the VS Code instructions in installer.rst emphasizes that we consider VS Code the IDE of choice, even for installer users

Sure but having duplicated instructions isn't great. I'll rephrase to emphasize / suggest vscode I guess, unless you have a specific other suggestion

@larsoner
Copy link
Member Author

@hoechenberger is this better? If so I'll push, if not let me know how you think it could be improved

image

And instructions

image

@drammock
Copy link
Member

I think having the VS Code instructions in installer.rst emphasizes that we consider VS Code the IDE of choice, even for installer users

I don't think we should be too forceful/opinionated here. Lots of folks like Spyder and PyCharm, and for some users, the best reason for picking a particular IDE is that someone else in your lab / department / institute uses it and can help you if you get stuck. I'm OK with @larsoner's suggestion of:

Set up Visual Studio Code or another IDE (instructions here)...

but I don't think we should get any more forceful than that.

@hoechenberger
Copy link
Member

I like this consolidated view, thanks Eric

@hoechenberger hoechenberger merged commit 071a98f into mne-tools:main Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

4 participants