Add vmin and vmax specification to mne.Evoked.animate_topomap#11073
Add vmin and vmax specification to mne.Evoked.animate_topomap#11073drammock merged 8 commits intomne-tools:mainfrom
vmin and vmax specification to mne.Evoked.animate_topomap#11073Conversation
drammock
left a comment
drammock
left a comment
There was a problem hiding this comment.
Note that I used the GitHub web UI to commit my earlier suggestion (about the changelog), so before making further changes you'll first need to pull down that new commit (git fetch origin && git merge --ff-only origin/issue-10725)
mne/evoked.py
Outdated
| .. versionadded:: 1.1.0 | ||
| %(vmin_vmax_topomap)s |
There was a problem hiding this comment.
in fact, my earlier comment was not quite correct (sorry!). I forgot to mention that if there is a verbose param it should always come last. So please move vmin/vmax to just before verbose. Also the .. versionadded:: bit should come after the parameter it's referring to, so switch the order of these two lines please (and also move them to before verbose).
mne/evoked.py
Outdated
| extrapolate=_EXTRAPOLATE_DEFAULT, verbose=None, | ||
| vmin=None, vmax=None): |
There was a problem hiding this comment.
here too, move vmin and vmax to come before verbose
There was a problem hiding this comment.
Thanks for your guidance (and patience!)
sappelhoff
changed the title
vmin and vmax specification to mne.Evoked.animate_topomap
|
LGTM! Thanks @matsvanes; this will merge when CIs finish running |
* upstream/main: (366 commits) BUG: Spectrum deprecation cleanup [circle deploy] (mne-tools#11115) Add API entry list and map (mne-tools#10999) Add legacy decorator (mne-tools#11097) [ENH, MRG] Add time-frequency epoch source estimation (mne-tools#11095) Revert "Add error message when conversion of EEG locs to [circle deploy] (mne-tools#11104) MRG: Fixes for mne-tools#11090 (mne-tools#11108) add test for edf units param (mne-tools#11105) BUG: Improve logic for bti (mne-tools#11102) add spectrum class (mne-tools#10184) ENH : add units parameter to read_raw_edf in case units is missing from the file (mne-tools#11099) ENH: Add temperature and galvanic (mne-tools#11090) Add error message when conversion of EEG locs to head space fails (mne-tools#11080) DOC: removed unnecessary line in PSF example (mne-tools#11085) FIX: Update helmet during ICP (mne-tools#11084) Fix various typos (mne-tools#11086) DOC: Rel BUG: don't assume that channel info contains particular keys (mne-tools#11074) [BUG] Fix plot_topomap with sphere="eeglab" (mne-tools#11081) Add `vmin` and `vmax` specification to `mne.Evoked.animate_topomap` (mne-tools#11073) Add _on_missing functionality to UpdateChannelsMixin (mne-tools#11077) ...
2 participants
Fixes #10725 .
Add
vminandvmaxspecification tomne.Evoked.animate_topomap