Skip to content

ENH: Add BIDS standard types#41

Merged
mkajola merged 3 commits intomne-tools:masterfrom
larsoner:bids
Aug 26, 2022
Merged

ENH: Add BIDS standard types#41
mkajola merged 3 commits intomne-tools:masterfrom
larsoner:bids

Conversation

@larsoner
Copy link
Copy Markdown
Member

@mkajola
Copy link
Copy Markdown
Collaborator

mkajola commented Aug 25, 2022 via email

@larsoner
Copy link
Copy Markdown
Member Author

The "Temperature" is generic in the BIDS spec, so it probably makes sense to make it generic here, too. I'm not sure if we'd need different types for different sensors (environmental, skin, ... ?), I'm inclined to just make the basic type here and let people's channel names specify what temperature is being measured.

Comment thread DictionaryTypes.txt Outdated
goodness_fit 1001 "Goodness of fit"
fnirs 1100 "Functional near-infrared spectroscopy"
temperature 1200 "Temperature"
galvanic 1300 "Galvanic skin response"
Copy link
Copy Markdown
Member

@hoechenberger hoechenberger Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should name the channel type eda and the description should be Electrodermal activity. GSR is an outdated term that ideally should also be eliminated from BIDS....

See also Wikipedia on the naming:

https://en.wikipedia.org/wiki/Electrodermal_activity?wprov=sfti1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest we do what BIDS does here. EDA is exploratory data analysis with my prior...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel quite strongly we should use EDA. I haven't read GSR in publications in quite a while

(But of course my literature selection is biased)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbrnr @sappelhoff any thoughts?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not so deeply entrenched in this nomenclature, but if the info in the wikipedia article is valid that "EDA" is a term to standardize the diverse previous terms, then I am all for it.

On the BIDS side we can (given the assumption is true that EDA is the new standard) then deprecate GSR and declare that people use EDA for future datasets.

In MNE-BIDS we can map both EDA and GSR (bids) to EDA (mne), and warn if we do a GSR->EDA mapping, that GSR is deprecated in BIDS.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ask some colleagues of mine who do (or did) peripheral measurements of anything "emotion", maybe they have an opinion

Copy link
Copy Markdown
Member

@hoechenberger hoechenberger Aug 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tl;dr: Both terms are used interchangeably, but there seems to be a consensus that EDA is to be preferred these days

So it seems that EDA and GSR are used interchangeably, but GSR mostly sticks around for historical reasons. In many publications, you'll find phrases like "... measured electrodermal activity (EDA; also known as galvanic skin response, GSR)". Like, this sort of double-naming appears to be kind of omnipresent.

I checked how software packages for EDA processing are named:

Sensors often come with both both names too:

In summary, my favorite would be eda, but I could live with gsr too – the community will understand both.

I veto against galvanic, though, as this is too generic, and I suppose it won't ring a bell for many folks.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for gsr then, as it'll make our lives a bit easier (we wouldn't have to discuss deprecating gsr in favor of eda at BIDS) and it seems to stick.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do gsr then, this also avoids @agramfort's brain freeze 😅

@hoechenberger
Copy link
Copy Markdown
Member

I'm inclined to just make the basic type here and let people's channel names specify what temperature is being measured.

+1 for doing that

@hoechenberger
Copy link
Copy Markdown
Member

LGTM, feel free to merge, anyone!
And thanks @larsoner, and @agramfrort and @sappelhoff for chiming in too

@mkajola mkajola merged commit 6d9ca9c into mne-tools:master Aug 26, 2022
@larsoner
Copy link
Copy Markdown
Member Author

Thanks for the quick reviews / conversations @mkajola @hoechenberger @sappelhoff @agramfort !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants