Conversation
|
The "Temperature" is generic in the BIDS spec, so it probably makes sense to make it generic here, too. I'm not sure if we'd need different types for different sensors (environmental, skin, ... ?), I'm inclined to just make the basic type here and let people's channel names specify what temperature is being measured. |
| goodness_fit 1001 "Goodness of fit" | ||
| fnirs 1100 "Functional near-infrared spectroscopy" | ||
| temperature 1200 "Temperature" | ||
| galvanic 1300 "Galvanic skin response" |
There was a problem hiding this comment.
We should name the channel type eda and the description should be Electrodermal activity. GSR is an outdated term that ideally should also be eliminated from BIDS....
See also Wikipedia on the naming:
There was a problem hiding this comment.
I would suggest we do what BIDS does here. EDA is exploratory data analysis with my prior...
There was a problem hiding this comment.
I feel quite strongly we should use EDA. I haven't read GSR in publications in quite a while
(But of course my literature selection is biased)
There was a problem hiding this comment.
I am not so deeply entrenched in this nomenclature, but if the info in the wikipedia article is valid that "EDA" is a term to standardize the diverse previous terms, then I am all for it.
On the BIDS side we can (given the assumption is true that EDA is the new standard) then deprecate GSR and declare that people use EDA for future datasets.
In MNE-BIDS we can map both EDA and GSR (bids) to EDA (mne), and warn if we do a GSR->EDA mapping, that GSR is deprecated in BIDS.
There was a problem hiding this comment.
I'll ask some colleagues of mine who do (or did) peripheral measurements of anything "emotion", maybe they have an opinion
There was a problem hiding this comment.
tl;dr: Both terms are used interchangeably, but there seems to be a consensus that EDA is to be preferred these days
So it seems that EDA and GSR are used interchangeably, but GSR mostly sticks around for historical reasons. In many publications, you'll find phrases like "... measured electrodermal activity (EDA; also known as galvanic skin response, GSR)". Like, this sort of double-naming appears to be kind of omnipresent.
I checked how software packages for EDA processing are named:
- LEDALAB
- pyEDA
- NeuroKit2 has an
edapackage - there's a Biopack Electrodermal Activity Analysis Module for "EDA/GSR Analysis"
Sensors often come with both both names too:
- iMotions EDA – Electrodermal Activity (GSR)
- BrainProducts GSR Sensor (no mention of EDA here though!)
In summary, my favorite would be eda, but I could live with gsr too – the community will understand both.
I veto against galvanic, though, as this is too generic, and I suppose it won't ring a bell for many folks.
There was a problem hiding this comment.
+1 for gsr then, as it'll make our lives a bit easier (we wouldn't have to discuss deprecating gsr in favor of eda at BIDS) and it seems to stick.
There was a problem hiding this comment.
Let's do gsr then, this also avoids @agramfort's brain freeze 😅
+1 for doing that |
|
LGTM, feel free to merge, anyone! |
|
Thanks for the quick reviews / conversations @mkajola @hoechenberger @sappelhoff @agramfort ! |
Adds two new channel types:
Quoting @hoechenberger: