Skip to content

Normalize date arrays before comparing #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mnbaccari merged 1 commit into from
Apr 29, 2025
Merged

Normalize date arrays before comparing #2

mnbaccari merged 1 commit into from
Apr 29, 2025

Conversation

@mnbaccari
Copy link
Owner

@mnbaccari mnbaccari commented Apr 29, 2025

Description of change

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@mnbaccari mnbaccari mentioned this pull request Apr 29, 2025
Merged
7 tasks
@coveralls
Copy link

coveralls commented Apr 29, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14737477252

Details

  • 10 of 16 (62.5%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.05%) to 76.307%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/persistence/SubjectChangedColumnsComputer.ts 10 16 62.5%
Files with Coverage Reduction New Missed Lines %
src/driver/sap/SapDriver.ts 1 82.75%
src/persistence/SubjectChangedColumnsComputer.ts 1 81.41%
src/logger/FileLogger.ts 2 51.67%
src/logger/AbstractLogger.ts 5 64.66%
Totals Coverage Status
Change from base Build 14737178750: -0.05%
Covered Lines: 18801
Relevant Lines: 23933
💛 - Coveralls

sgarner
sgarner approved these changes Apr 29, 2025
View reviewed changes
Copy link

@sgarner sgarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mnbaccari mnbaccari marked this pull request as ready for review April 29, 2025 22:17
@mnbaccari mnbaccari merged commit 398777d into fix-array-column-changed Apr 29, 2025
79 of 80 checks passed
@mnbaccari mnbaccari deleted the data-array-normalization branch April 29, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sgarner sgarner sgarner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mnbaccari @coveralls @sgarner