Use Julia's finalizer implementation#78
Merged
qinsoon merged 8 commits intommtk:masterfrom Jul 25, 2023
Merged
Conversation
qinsoon
force-pushed
the
use-julia-finalizer-impl
branch
from
c6a3fc6 to
822ccb5
Compare
udesou
approved these changes
Jul 24, 2023
Contributor
udesou
left a comment
udesou
left a comment
There was a problem hiding this comment.
Looks good, and much cleaner with reusing their code. Hopefully future changes they make with their finaliser code don't affect whatever we have on the MMTk side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates to mmtk/julia#22.