Skip to content

Update Julia upstream 43bf2c8#71

Merged
qinsoon merged 18 commits intommtk:masterfrom
qinsoon:update-julia-upstream-43bf2c8
Sep 1, 2023
Merged

Update Julia upstream 43bf2c8#71
qinsoon merged 18 commits intommtk:masterfrom
qinsoon:update-julia-upstream-43bf2c8

Conversation

@qinsoon
Copy link
Copy Markdown
Member

@qinsoon qinsoon commented Jul 3, 2023

Updates to mmtk/julia#21.

@qinsoon
Copy link
Copy Markdown
Member Author

qinsoon commented Jul 4, 2023

This PR is not ready to merge. Somehow, sticky immix failed to build on the dev machine I am using. It seems like some objects that should be alive are collected by the GC. It could be related with write barrier, I did not look further into it.

@qinsoon qinsoon self-assigned this Aug 18, 2023
@qinsoon
Copy link
Copy Markdown
Member Author

qinsoon commented Aug 29, 2023

This PR is not ready to merge. Somehow, sticky immix failed to build on the dev machine I am using. It seems like some objects that should be alive are collected by the GC. It could be related with write barrier, I did not look further into it.

This is fixed in mmtk/julia@8eab37d. It turns out that there is an object update that does not have a write barrier in Julia code. So the bug exists in master as well.

@qinsoon qinsoon marked this pull request as ready for review August 29, 2023 23:08
@qinsoon qinsoon requested a review from udesou August 29, 2023 23:08
github-merge-queue bot pushed a commit to mmtk/mmtk-core that referenced this pull request Aug 30, 2023
This PR changes `VMSpace` to multiple discontiguous regions as VM space.
This PR is used in mmtk/mmtk-julia#71 to support
system and package images.
* add an `ExternalPageResource` to manage the discontiguous regions.
* implement `VMSpace` with `ExternalPageResource`. `VMSpace` no longer
uses `ImmortalSpace`.
* rename `lazy_init_vm_space` to `set_vm_space`, as we allow setting vm
space multiple times with non overlapping regions.

---------

Co-authored-by: Kunal Sareen <[email protected]>
github-merge-queue bot pushed a commit to mmtk/mmtk-core that referenced this pull request Aug 31, 2023
This PR changes `VMSpace` to multiple discontiguous regions as VM space.
This PR is used in mmtk/mmtk-julia#71 to support
system and package images.
* add an `ExternalPageResource` to manage the discontiguous regions.
* implement `VMSpace` with `ExternalPageResource`. `VMSpace` no longer
uses `ImmortalSpace`.
* rename `lazy_init_vm_space` to `set_vm_space`, as we allow setting vm
space multiple times with non overlapping regions.

---------

Co-authored-by: Kunal Sareen <[email protected]>
Copy link
Copy Markdown
Contributor

@udesou udesou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

# This seems to be a regression from upstream when we merge with upstream 43bf2c8.
# The required string int.jl does not appear in the output even if I test with the stock Julia code.
# I do not know what is wrong, but at this point, I dont want to spend time on it.
'@test occursin("int.jl", code)' "$JULIA_PATH/test/cmdlineargs.jl"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is odd, but I guess it might just be a bug in their master. If it doesn't work even with stock Julia, then I agree we shouldn't worry about it.

@qinsoon qinsoon merged commit d2fa7fa into mmtk:master Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants