Merged
Conversation
. Correct prototype for `run_finalizer`. . Remove `jl_mmtk_gc_alloc_default_llvm`, no longer needed. . Remove calls to `gc_time_mallocd_array_*`, only needed with `GC_TIME`. . Remove call to `verify_parent1`, only needed with `GC_VERIFY`.
Member
|
The test failure in JULIA test/ccall
Running parallel tests with:
nworkers() = 1
nthreads() = 1
Sys.CPU_THREADS = 2
Sys.total_memory() = 6.787 GiB
Sys.free_memory() = 5.601 GiB
Test (Worker) | Time (s) | GC (s) | GC % | Alloc (MB) | RSS (MB)
ccall (1) | started at 2023-03-14T00:59:52.698
thread '<unnamed>' panicked at 'MMTk collection has been initialized (was initialize_collection() already called before?)', /home/runner/.cargo/git/checkouts/mmtk-core-3306bdeb8eb4322b/08fd8ab/src/memory_manager.rs:459:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: failed to initiate panic, error 5Is the code path related with |
Collaborator
Author
I hadn't thought that would be possible; studying it now. |
Collaborator
Author
|
Pushed a commit that should fix the call path to |
qinsoon
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge only with mmtk/julia#5.
run_finalizer.jl_mmtk_gc_alloc_default_llvm, no longer needed.gc_time_mallocd_array_*, only needed withGC_TIME.verify_parent1, only needed withGC_VERIFY.