Draft
Conversation
This removes the need of `self_mut` by putting fields into Mutex or converting fields into atomic types.
This was referenced Sep 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT: This PR has undergone rudimentary tests with Map32. It works, but it has several problems:
Map32::prev_linkandMap32::next_linkinto theMutex, but much synchronization is still needed to guard the queries of "next contiguous chunks", "contiguous chunks size", etc. It is much easier to replace the doubly linked list with a per-space data structure before doing this PR. See Refactor VMMap and introduce ChunkResource #932 (comment)descriptor_mapis now protected by aMutex, but it is used bySpace::in_spacewhich is used byPlanTraceObject. It will hurt performance. We should replacedescriptor_mapwith SFT as we discussed in Refactor VMMap and introduce ChunkResource #932 (comment) before proceeding with this PR.This removes the need of
self_mutby putting fields into Mutex or converting fields into atomic types.