Add ExternalPageResource and allow discontiguous VM space#864
Merged
qinsoon merged 13 commits intommtk:masterfrom Aug 31, 2023
Merged
Add ExternalPageResource and allow discontiguous VM space#864qinsoon merged 13 commits intommtk:masterfrom
qinsoon merged 13 commits intommtk:masterfrom
Conversation
Member
Author
|
Currently we cannot run with MSRV 1.61 at the moment. We have a dependency chain |
Member
Author
|
From rust-cli/env_logger#273, the options for us are:
I would suggest 2. It does not look like cargo/Rust will improve on this any time soon, and 2 does no harm. |
Collaborator
|
We can also play our old trick of locking a dependency to a specific version until the problem is solved. We once did this for diff --git a/Cargo.toml b/Cargo.toml
index db4da419d..6f07eb851 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -28,6 +28,7 @@ delegate = "0.9.0"
downcast-rs = "1.1.1"
enum-map = "2.4.2"
env_logger = "0.10.0"
+is-terminal = "=0.4.7" # latest version requires MSRV 1.63
itertools = "0.10.5"
jemalloc-sys = { version = "0.5.3", features = ["disable_initial_exec_tls"], optional = true }
lazy_static = "1.1" |
qinsoon
force-pushed
the
discontiguous-vm-space
branch
from
8e06b28 to
7d19f58
Compare
qinsoon
force-pushed
the
discontiguous-vm-space
branch
from
7d19f58 to
7fc052e
Compare
wks
requested changes
Aug 15, 2023
k-sareen
reviewed
Aug 28, 2023
Co-authored-by: Kunal Sareen <[email protected]>
Member
Author
|
binding-refs |
qinsoon
added
the
PR-testing
Member
Author
|
This PR is ready for review again. @wks |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
qinsoon
removed
the
PR-testing
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
We once used `ImmortalSpace` for VM space. #864 introduced a separate policy for `VMSpace`, and these code in `ImmortalSpace` became dead code since then. This PR removes the dead code. --------- Co-authored-by: Kunal Sareen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
VMSpaceto multiple discontiguous regions as VM space. This PR is used in mmtk/mmtk-julia#71 to support system and package images.ExternalPageResourceto manage the discontiguous regions.VMSpacewithExternalPageResource.VMSpaceno longer usesImmortalSpace.lazy_init_vm_spacetoset_vm_space, as we allow setting vm space multiple times with non overlapping regions.