Merged
Conversation
caizixian
approved these changes
Feb 7, 2023
Member
caizixian
left a comment
caizixian
left a comment
There was a problem hiding this comment.
I’ve been debugging this with Wenyu. This looks good to me. Before this fix, the write is incorrect, and could sometimes be out of bound of the vector, corrupting the header of adjacent malloc’ed cells.
wenyuzhao
added a commit
to wenyuzhao/mmtk-core
that referenced
this pull request
Mar 20, 2023
`fl` has type of `&&CommonFreeListPageResource`. `fl as *const _ as *mut _` will first implicitly convert `fl` to `*const &CommonFreeListPageResource`, then to `*mut CommonFreeListPageResource`. The second conversion from `*const` to `*mut` is incorrect.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flhas type of&&CommonFreeListPageResource.fl as *const _ as *mut _will first implicitly convertflto*const &CommonFreeListPageResource, then to*mut CommonFreeListPageResource. The second conversion from*constto*mutis incorrect.