Fix/remove sizeclasses v1.9.2+rai#41
Merged
udesou merged 2 commits intommtk:v1.9.2+RAIfrom Feb 28, 2024
Merged
Conversation
Stop using Julia's size classes when using MMTk
udesou
pushed a commit
to udesou/julia
that referenced
this pull request
Aug 19, 2024
Without this change, the compiler fails to notice that `env_threads isa Int` in the fall-through case, leading to a union-split with a branch that is in fact unreachable: ``` 43 ┄ %109 = φ (mmtk#41 => %105, mmtk#42 => %108)::Union{Nothing, Int64} │ %110 = (%109 isa Int64)::Bool └─── goto mmtk#45 if not %110 ... 45 ─ %126 = π (%109, Nothing) │ Base.convert(Int64, %126)::Union{} └─── unreachable ``` After this change, the union-split is eliminated. Co-authored-by: Jeff Bezanson <[email protected]>
qinsoon
pushed a commit
to qinsoon/julia
that referenced
this pull request
Nov 6, 2025
…g#59889) Stdlib: ArgTools URL: https://github.com/JuliaIO/ArgTools.jl.git Stdlib branch: master Julia branch: master Old commit: 1314758 New commit: 89d1959 Julia version: 1.13.0-DEV ArgTools version: 1.1.2(Does not match) Bump invoked by: @IanButterworth Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaIO/ArgTools.jl@1314758...89d1959 ``` $ git log --oneline 1314758..89d1959 89d1959 Merge pull request mmtk#41 from JuliaIO/dependabot/github_actions/actions/checkout-5 c0bdfea build(deps): bump actions/checkout from 4 to 5 ``` Co-authored-by: IanButterworth <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.