Skip to content

Julia's debug build and debug CI test failing#26

Merged
udesou merged 1 commit intommtk:masterfrom
udesou:fix/enabling-debug-build
Aug 23, 2023
Merged

Julia's debug build and debug CI test failing#26
udesou merged 1 commit intommtk:masterfrom
udesou:fix/enabling-debug-build

Conversation

@udesou
Copy link
Copy Markdown

@udesou udesou commented Aug 9, 2023

Fixed issue that prevented building Julia or running tests with Julia's debug build. The MMTk library wasn't being copied and the tests used julia instead of julia-debug before running tests.

@udesou udesou requested a review from qinsoon August 9, 2023 01:18
Copy link
Copy Markdown
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon
Copy link
Copy Markdown
Member

qinsoon commented Aug 23, 2023

Should we merge this?

@udesou
Copy link
Copy Markdown
Author

udesou commented Aug 23, 2023

Yes. Sorry, I forgot about this PR.

@udesou udesou merged commit beb4a08 into mmtk:master Aug 23, 2023
qinsoon pushed a commit that referenced this pull request Sep 1, 2023
It's possible for PiNodes to effectively imply statically the condition
of a Core.ifelse. For example:
```julia
    23 ─ %60  = Core.ifelse(%47, false, true)::Bool
    │    %61  = Core.ifelse(%47, %58, false)::Union{Missing, Bool}
    25 ─        goto #27 if not %60
    26 ─ %65  = π (%61, Bool)
    └───        ...
```

In basic block #26, the PiNode gives us enough information to conclude
that `%47 === false` if control flow reaches that point. The previous
code incorrectly assumed that this kind of pruning would only be done
for PhiNodes.

Resolves JuliaLang#50276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants