[Model Monitoring] Fix event loop blocking during model endpoint creation (ML-11826) #9186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion (ML-11826) Use run_in_threadpool to wrap synchronous DB operations in _create_model_endpoint_limited to prevent blocking the async event loop when creating model endpoints during serving function deployment. This ensures the API server remains responsive while processing large batches of model endpoint creation requests.
gtopper
reviewed
Jan 11, 2026
gtopper
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix event loop blocking during model endpoint creation by using
run_in_threadpoolto wrap synchronous DB operations.Changes Made
run_function_with_new_db_sessioncall inrun_in_threadpoolin_create_model_endpoint_limitedawaitkeyword for the async operationWhy This Change
When deploying a serving function with many models (e.g., 5000), the synchronous DB operations for creating model endpoints would block the async event loop. This prevented the API server from handling other requests and could cause timeouts.
Using
run_in_threadpoolmoves the synchronous DB work to a thread pool, keeping the event loop responsive while still processing the model endpoint creation.Testing
test_app_flow[True-True]system test successfullyReference