[Model Monitoring] Fix TimescaleDB stream writer table not found error (ML-11807) #9182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The model-monitoring-stream pod failed when flushing batches to TimescaleDB
with "Table does not exist" errors. Root cause: TimescaleDBConnector (API server)
auto-generates database name as 'mlrun_mm_{system_id}', but TimescaleDBStoreyTarget
(stream) used the original profile database, causing a mismatch.
- Add shared get_tsdb_database_name() function in helpers.py
- Update TimescaleDBConnector to use shared function
- Update TimescaleDBStoreyTarget to use shared function for consistent naming
Fixes: ML-11807
gtopper
reviewed
Jan 8, 2026
Collaborator
gtopper
left a comment
gtopper
left a comment
There was a problem hiding this comment.
Looks good. Could benefit from a regression test if one can be added without too much effort.
…1807) Add tests to verify consistent database naming between TimescaleDBConnector and TimescaleDBStoreyTarget components. These tests cover the shared get_tsdb_database_name() helper function introduced in the fix. - Add TestGetTsdbDatabaseName class with 6 test cases in test_helpers.py - Add TestTimescaleDBStoreyTargetDatabaseResolution with 4 test cases - Fix pre-existing bug in error message (datastore_profile.type.__name__ → type) Reference: ML-11807
gtopper
reviewed
Jan 8, 2026
gtopper
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the model-monitoring-stream pod failing when flushing batches to TimescaleDB with "Table does not exist" errors.
Root Cause
TimescaleDBConnector(API server side) auto-generates database name asmlrun_mm_{system_id}, butTimescaleDBStoreyTarget(stream side) used the original profile database directly, causing a mismatch. Tables were created inmlrun_mm_{system_id}but stream tried to write topostgres.Changes Made
get_tsdb_database_name()function inmlrun/common/model_monitoring/helpers.pyTimescaleDBConnector._determine_database_name()to use the shared functionTimescaleDBStoreyTarget.__init__()to use the shared function for consistent database namingTesting
Checklist
Reference