[Model Monitoring] Fix event loop blocking during model endpoint creation (ML-11826) #9174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion (ML-11826) The `_create_model_endpoint_limited` async function was calling `run_function_with_new_db_session()` synchronously, which blocked the event loop while creating model endpoints. This caused: - Deploy API responses to timeout (nginx 180s proxy-read-timeout) - UI to become unresponsive during deployment - Server completed in ~7s but response never reached client Fix: Wrap the sync DB operation with `run_in_threadpool` to execute it in a thread pool worker without blocking the event loop.
liranbg
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a critical issue where deploying serving functions with many models (e.g., 5000) would cause:
Root Cause
The
_create_model_endpoint_limitedasync function was callingrun_function_with_new_db_session()synchronously, which blocked the event loop while creating model endpoints in the background task.Changes Made
run_in_threadpoolto execute it in a thread pool worker without blocking the event loopTesting
Reference