[Runtime] Remove function level import and fix circular import #9173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranbg
requested changes
Jan 7, 2026
mlrun/runtimes/__init__.py
Outdated
Comment on lines
88
to
89
| RuntimeKinds.resolve_nuclio_runtime = staticmethod(resolve_nuclio_runtime) | ||
| RuntimeKinds.resolve_nuclio_sub_kind = staticmethod(resolve_nuclio_sub_kind) |
Member
There was a problem hiding this comment.
This is not a good practice. move it to constants.py . I dont see a reason why not to put these functions under runtime class. if you need, use them as helper functions but make sure callees call these functions directly and not via the class overload functions.
Contributor
Author
There was a problem hiding this comment.
The nuclio resolver helpers (resolve_nuclio_runtime / resolve_nuclio_sub_kind) cannot live in constants.py because they depend on nuclio runtime classes (e.g. RemoteRuntime), which import base.py and create an import cycle.
…KindsBase class from constants.py. This keeps constants.py free of nuclio runtimes imports to avoid cycles, while not breaking BC of the nuclio resolver helper functions
…solute path instead of relatives in required files
liranbg
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This is a following PR of #9121 that fixes a circular import in the runtime module and removes the need for function-level import.
RuntimeKindswas moved into a dedicated module (mlrun/runtimes/constants.py) so it can be imported without pulling in nuclio runtime modules. The nuclio resolver helpers (resolve_nuclio_runtime/resolve_nuclio_sub_kind) cannot live inconstants.pybecause they depend on nuclio runtime classes (e.g.RemoteRuntime), which importbase.pyand create an import cycle.To preserve backwards compatibility, the resolvers remain available as:
RuntimeKinds.resolve_nuclio_runtimeandRuntimeKinds.resolve_nuclio_sub_kind,implemented in
mlrun/runtimes/__init__.pyand attached asstaticmethods.🛠️ Changes Made
RuntimeKindstomlrun/runtimes/constants.pyconstants.pyto avoid import cyclesmlrun/runtimes/__init__.pyRuntimeKinds.resolve_nuclio_*API working viastaticmethodassignment✅ Checklist
🧪 Testing
🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes