[Model Monitoring] Add configurable TimescaleDB connection pool timeout (ML-11775) #9172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtopper
reviewed
Jan 7, 2026
|
|
||
| def test_pool_uses_configured_timeout(self): | ||
| """Test that ConnectionPool is created with timeout from config.""" | ||
| import mlrun.config |
Collaborator
There was a problem hiding this comment.
Should be fine to import at the top?
Collaborator
There was a problem hiding this comment.
Or maybe not, because of the patching?
Member
Author
There was a problem hiding this comment.
You're right - moved the import to the top. The patching is for ConnectionPool, not for the config module, so it doesn't interfere.
gtopper
reviewed
Jan 7, 2026
tests/model_monitoring/db/tsdb/timescaledb/test_timescaledb_connection.py
Show resolved
Hide resolved
…ut (ML-11775) Add a new config option `model_endpoint_monitoring.tsdb.connection_pool_timeout` to control the TimescaleDB connection pool timeout. Default is 120 seconds (previously hardcoded to 30 seconds). This allows API requests to wait longer for a database connection from the pool under high load, instead of timing out prematurely at 30 seconds.
gtopper
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
model_endpoint_monitoring.tsdb.connection_pool_timeoutto control TimescaleDB connection pool timeoutChanges Made
connection_pool_timeoutconfig inmlrun/config.pyundermodel_endpoint_monitoring.tsdbTimescaleDBConnection.poolproperty to use the configurable timeout