[Model Monitoring] Fix TimescaleDB endpoint count to query correct tables (ML-11624) #9164
+193
−213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxtkr77
force-pushed
the
ML-11624-timescaledb-endpoint-count
branch
from
2969be0 to
e33effb
Compare
gtopper
reviewed
Jan 11, 2026
tests/model_monitoring/db/tsdb/timescaledb/test_timescaledb_queries_aggregation.py
Outdated
Show resolved
Hide resolved
| # Build application filter and params | ||
| app_filter_metrics = "" | ||
| app_filter_results = "" | ||
| params: list = [] |
Member
There was a problem hiding this comment.
Suggested change
| params: list = [] |
| self, | ||
| start: Optional[datetime.datetime] = None, | ||
| end: Optional[datetime.datetime] = None, | ||
| application_names: Optional[list[str]] = None, |
Member
There was a problem hiding this comment.
in L448 you check if application_names is str (and if so convert it to a list) so please adjust the type annotation accordingly
Suggested change
| application_names: Optional[list[str]] = None, | |
| application_names: Optional[list[str] | str] = None,, |
…bles (ML-11624) Model Monitoring App was showing "Endpoints: 0" when using TimescaleDB but correctly showed endpoints when using V3IO. The root cause was that count_processed_model_endpoints was querying the PREDICTIONS table, which doesn't have an application_name column, instead of METRICS and APP_RESULTS tables which do have this column. Changes: - Move count_processed_model_endpoints from TimescaleDBPredictionsQueries to TimescaleDBConnector - Use SQL UNION to efficiently count endpoints from both METRICS and APP_RESULTS tables in a single query - Store _tables and _pre_aggregate_manager as instance variables in connector for cross-table operations - Remove unused _count_with_application_join and _count_simple methods - Update tests to use connector fixture directly Reference: ML-11624
alxtkr77
force-pushed
the
ML-11624-timescaledb-endpoint-count
branch
from
e33effb to
f67ad32
Compare
…eries_aggregation.py Co-authored-by: Gal Topper <[email protected]>
assaf758
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes bug where Model Monitoring App shows "Endpoints: 0" when using TimescaleDB but correctly shows endpoints with V3IO.
Root cause:
count_processed_model_endpointswas querying the PREDICTIONS table, which doesn't have anapplication_namecolumn, instead of METRICS and APP_RESULTS tables which have this column.Changes Made
count_processed_model_endpointsfromTimescaleDBPredictionsQueriestoTimescaleDBConnector_tablesand_pre_aggregate_manageras instance variables in connector for cross-table operations_count_with_application_joinand_count_simplemethodsconnectorfixture directlyTesting
Checklist
ruff formatruff checklintingReference