Skip to content

[CI] Better Go Test Summary #9163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
quaark merged 1 commit into from
Jan 6, 2026
Merged

[CI] Better Go Test Summary #9163

quaark merged 1 commit into from
Jan 6, 2026

Conversation

@quaark
Copy link
Member

@quaark quaark commented Jan 6, 2026

📝 Description

The test output is not ideal to read and find the issues.
We are now using https://github.com/gotestyourself/gotestsum which creates a nicer test summary when running the tests (see example below from orca).

🛠️ Changes Made

  • The go Makefile ensures the gotestsum binary exists in the required version
  • The go Makefile

✅ Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR

Summary Example

(from orca)

=== Failed
=== FAIL: frameworks/clients/clients/cache/inmemory TestCacheClientTestSuite/TestDelete (0.00s)
26.01.06 09:58:20.584 (D)                test.cache Setting cache item {"ctx": "952c869a-bdc7-48ea-8ae9-ce0286aed51f", "key": "TestKey", "ttl": "5s"}
26.01.06 09:58:20.584 (D)                test.cache Starting cache invalidation loop {"ctx": "d1ad6493-906a-4f56-a0c4-537a7061b068"}
26.01.06 09:58:20.585 (D)                test.cache Deleting cache key {"ctx": "952c869a-bdc7-48ea-8ae9-ce0286aed51f", "key": "TestKey"}
26.01.06 09:58:20.585 (D)                test.cache Deleting cache key {"ctx": "952c869a-bdc7-48ea-8ae9-ce0286aed51f", "key": "TestKey"}
26.01.06 09:58:20.585 (D)                test.cache Setting cache item {"ctx": "952c869a-bdc7-48ea-8ae9-ce0286aed51f", "key": "TestKey", "ttl": "5s"}
26.01.06 09:58:20.585 (D)                test.cache Getting cache item {"ctx": "952c869a-bdc7-48ea-8ae9-ce0286aed51f", "key": "TestKey"}
26.01.06 09:58:20.585 (D)                test.cache Deleting cache key {"ctx": "952c869a-bdc7-48ea-8ae9-ce0286aed51f", "key": "TestKey"}
    client_test.go:125: 
                Error Trace:    /Users/Adam_Melnick/iguazio/misc_workspace/orca/backend/go/frameworks/clients/clients/cache/inmemory/client_test.go:125
                                                        /Users/Adam_Melnick/go/pkg/mod/golang.org/[email protected]/src/runtime/asm_arm64.s:1268
                Error:          Not equal: 
                                expected: "TestValuebla"
                                actual  : "TestValue"
                                
                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1 +1 @@
                                -TestValuebla
                                +TestValue
                Test:           TestCacheClientTestSuite/TestDelete
                Messages:       Expected the popped value to match the inserted value
26.01.06 09:58:20.585 (D)                test.cache Stopping cache client {"ctx": "952c869a-bdc7-48ea-8ae9-ce0286aed51f"}
26.01.06 09:58:20.585 (D)                test.cache Stopping cache invalidation loop {"ctx": "d1ad6493-906a-4f56-a0c4-537a7061b068"}
    --- FAIL: TestCacheClientTestSuite/TestDelete (0.00s)

=== FAIL: frameworks/clients/clients/cache/inmemory TestCacheClientTestSuite (6.01s)

=== FAIL: subdomains/authentication/transport/mappers TestCookieMapperTestSuite/TestGetRefreshTokenFromRequestCookies/Cookie_present_but_wrong_name (0.00s)
    cookie_test.go:224: 
                Error Trace:    /Users/Adam_Melnick/iguazio/misc_workspace/orca/backend/go/subdomains/authentication/transport/mappers/cookie_test.go:224
                                                        /Users/Adam_Melnick/go/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                Error:          Not equal: 
                                expected: "asd"
                                actual  : ""
                                
                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1 +1 @@
                                -asd
                                +
                Test:           TestCookieMapperTestSuite/TestGetRefreshTokenFromRequestCookies/Cookie_present_but_wrong_name
        --- FAIL: TestCookieMapperTestSuite/TestGetRefreshTokenFromRequestCookies/Cookie_present_but_wrong_name (0.00s)

=== FAIL: subdomains/authentication/transport/mappers TestCookieMapperTestSuite/TestGetRefreshTokenFromRequestCookies (0.00s)
    --- FAIL: TestCookieMapperTestSuite/TestGetRefreshTokenFromRequestCookies (0.00s)

=== FAIL: subdomains/authentication/transport/mappers TestCookieMapperTestSuite (0.10s)

DONE 1027 tests, 5 failures in 7.019s
make[1]: *** [test-unit] Error 1
make: *** [test-unit] Error 2
estGetRefreshTokenFromRequestCookies/Cookie_present_but_wrong_name (0.00s)
    cookie_test.go:224: 
                Error Trace:    /Users/Adam_Melnick/iguazio/misc_workspace/orca/backend/go/subdomains/authentication/transport/mappers/cookie_test.go:224
                                                        /Users/Adam_Melnick/go/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                Error:          Not equal: 
                                expected: "asd"
                                actual  : ""
                                
                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1 +1 @@
                                -asd
                                +
                Test:           TestCookieMapperTestSuite/TestGetRefreshTokenFromRequestCookies/Cookie_present_but_wrong_name
        --- FAIL: TestCookieMapperTestSuite/TestGetRefreshTokenFromRequestCookies/Cookie_present_but_wrong_name (0.00s)

=== FAIL: subdomains/authentication/transport/mappers TestCookieMapperTestSuite/TestGetRefreshTokenFromRequestCookies (0.00s)
    --- FAIL: TestCookieMapperTestSuite/TestGetRefreshTokenFromRequestCookies (0.00s)

=== FAIL: subdomains/authentication/transport/mappers TestCookieMapperTestSuite (0.05s)

DONE 1027 tests, 5 failures in 6.984s
make[1]: *** [test-unit] Error 1
make: *** [test-unit] Error 2

@quaark quaark requested review from a team and TomerShor as code owners January 6, 2026 08:50
@quaark quaark merged commit 5243ab3 into mlrun:development Jan 6, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liranbg liranbg liranbg approved these changes

@TomerShor TomerShor Awaiting requested review from TomerShor TomerShor is a code owner

Assignees

No one assigned

Labels

area/server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quaark @liranbg