Skip to content

Conversation

@elbamit
Copy link
Contributor

@elbamit elbamit commented Jan 6, 2026

📝 Description

Fix an issue where translate_secret_token expected to get a list of secret tokens, but got a dict from extract_and_validate_tokens_info.


🛠️ Changes Made

  • Make translate_secret_token private function and refactor to correctly handle dict instead of list of tokens
  • Removed mocking of translate_secret_token in test.

✅ Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR
  • I confirmed whether my changes are covered by system tests
    • If yes, I ran all relevant system tests and ensured they passed before submitting this PR
    • I updated existing system tests and/or added new ones if needed to cover my changes
  • If I introduced a deprecation:

🧪 Testing

  • Removed mock in test
  • Reproduced the issue, then saw it resolved after fix

🔗 References


🚨 Breaking Changes?

  • Yes (explain below)
  • No

🔍️ Additional Notes

…alidate_tokens_info returns a dict but translate_secret_token expected a list
Copy link
Member

@Yacouby Yacouby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomerShor TomerShor merged commit 83ab40d into mlrun:development Jan 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants