[Auth] Enhance secret token handling with user ID filtering #9154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….py` to streamline the mocking of HTTPRunDB connection flow for OAuth tests, enhancing test maintainability and clarity.
elbamit
reviewed
Jan 5, 2026
| return secret_tokens | ||
|
|
||
|
|
||
| def validate_secret_tokens( |
Contributor
There was a problem hiding this comment.
validate_secret_tokens checks for:
nameexistencetokenexistencesub= user- looks for duplicates
extract_and_validate_tokens_info checks for:
nameexistencesubexistenceexpexistencesub= user- looks for duplicates
I think they can be merged into a single function.
If we do decide to keep it separate, let's rename it since it doesn't do just validation, but it actually filters the list of tokens.
Member
Author
There was a problem hiding this comment.
I will do it on a following pr
10 tasks
liranbg
added a commit
that referenced
this pull request
Jan 5, 2026
### 📝 Description Follow-up to #9154. Refactors secret token validation by removing the standalone `validate_secret_tokens` function and unifying validation logic into `extract_and_validate_tokens_info`. --- ### 🛠️ Changes Made - Removed redundant `validate_secret_tokens` function from `mlrun/auth/utils.py` - Unified token validation into `extract_and_validate_tokens_info` with a new `filter_by_authenticated_id` parameter - Updated `load_and_prepare_secret_tokens` to use the unified validation function - Updated tests to reflect the refactored validation logic --- ### ✅ Checklist - [ ] I updated the documentation (if applicable) - [x] I have tested the changes in this PR - [ ] I confirmed whether my changes are covered by system tests - [ ] If yes, I ran all relevant system tests and ensured they passed before submitting this PR - [ ] I updated existing system tests and/or added new ones if needed to cover my changes - [ ] If I introduced a deprecation: - [ ] I followed the [Deprecation Guidelines](./DEPRECATION.md) - [ ] I updated the relevant Jira ticket for documentation --- ### 🧪 Testing - Unit tests updated to cover the refactored validation logic - Tests verify token filtering by authenticated user ID with the new `filter_by_authenticated_id` parameter --- ### 🔗 References - Ticket link: N/A - Related PR: #9154 --- ### 🚨 Breaking Changes? - [ ] Yes (explain below) - [x] No --- ### 🔍️ Additional Notes This is a code cleanup PR that consolidates duplicate validation logic introduced in #9154.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This update introduces the ability to filter secret tokens based on the authenticated user ID. The
load_and_prepare_secret_tokensfunction now accepts an optionalauth_user_idparameter, allowing for more granular control over which tokens are loaded.🛠️ Changes Made
load_and_prepare_secret_tokensto acceptauth_user_idand filter tokens accordingly.get_jwt_subjectto extract the 'sub' claim from JWT tokens.sync_secret_tokensfunction to utilize the authenticated user ID when loading secret tokens.✅ Checklist
🧪 Testing
with/without tokens belong to my user
🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes