-
Notifications
You must be signed in to change notification settings - Fork 294
[Requirements] Bump nuclio-jupyter #9152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
liranbg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you update deps lock on all targets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR bumps the nuclio-jupyter dependency from version 0.11.2/0.11.3 to 0.12.0 as part of issue NUC-704. The upgrade removes the jupyter-server dependency and all its transitive dependencies from the locked requirements files.
- Updated nuclio-jupyter version constraint in requirements.txt from
~=0.11.2to~=0.12.0 - Updated all locked-requirements.txt files with the new version hashes
- Removed jupyter-server and its 20+ transitive dependencies from all locked requirements files
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| requirements.txt | Updated nuclio-jupyter version constraint to ~=0.12.0 |
| dockerfiles/test/locked-requirements.txt | Updated nuclio-jupyter to 0.12.0, removed jupyter-server dependencies |
| dockerfiles/test-system/locked-requirements.txt | Updated nuclio-jupyter to 0.12.0, removed jupyter-server dependencies |
| dockerfiles/mlrun/locked-requirements.txt | Updated nuclio-jupyter to 0.12.0, removed jupyter-server dependencies |
| dockerfiles/mlrun-kfp/locked-requirements.txt | Updated nuclio-jupyter to 0.12.0, removed jupyter-server dependencies |
| dockerfiles/mlrun-api/locked-requirements.txt | Updated nuclio-jupyter to 0.12.0, removed jupyter-server dependencies |
| dockerfiles/jupyter/locked-requirements.txt | Updated nuclio-jupyter to 0.12.0, removed jupyter-server dependencies |
| dockerfiles/gpu/locked-requirements.txt | Updated nuclio-jupyter to 0.12.0, removed jupyter-server dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@liranbg Running make upgrade-mlrun-deps-lock seems to get boto3 back to the locked requirements but still fails in sphinx building maybe missing installation of extras-requirements |
discussed offline and agreed to add extras to docs as now nuclio jupyter comes without boto3 |
Bump nuclio-jupyter to version 0.12.0 as part of https://iguazio.atlassian.net/browse/NUC-704
No breaking changes
Tested by CI